Add new schema options #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rkistner let me know what you think about the naming suggestions. I agree with them, but I'm not sure if we want a divergence between the JSON key internally and the public name? If that's ok I can apply the suggestion here and on the other PRs for this feature. |
|
I'd love to have |
|
I like Steven's suggestions here. It's fine if it diverges from the json, as long as it's consistent across the SDKs. |
stevensJourney
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the new table options introduced in version 0.3.13 of the core extension, namely:
include_old(either a boolean or an array of column names): Adds anoldentry to theps_crud.dataJSON object that includes old values for updates.include_old_only_when_changed: Skip unchanged values from updates.include_metadata: Adds a_metadatacolumn that can be written to for updates. It's reported throughCrudEntry.metadataafterwards.ignore_empty_update: Don't createps_crudentries forUPDATEstatements that didn't change any values.Most of this feature is tested in the core extension, this adds a few simple tests ensuring we forward options correctly.